Github user caneGuy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18730#discussion_r135026463
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -40,6 +40,8 @@ private[spark] class ChunkedByteBuffer(var chunks:
Array[ByteBuffer]) {
require(chunks != null, "chunks must not be null")
require(chunks.forall(_.position() == 0), "chunks' positions must be 0")
+ private val NIO_BUFFER_LIMIT = 64 * 1024 * 1024 // Chunk size in bytes
--- End diff --
actually i did not tested too much, it depends on value from our
cluster.And i do some simple test then found 64mb will not affect perfomance
compared with logic before.And benifit is we only need one buffer cache for
block larger than 64 mb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
