Github user neoremind commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18964#discussion_r135081475
  
    --- Diff: 
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
 ---
    @@ -210,6 +210,14 @@ private TransportClient createClient(InetSocketAddress 
address)
           .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, 
conf.connectionTimeoutMs())
           .option(ChannelOption.ALLOCATOR, pooledAllocator);
     
    +    if (conf.receiveBuf() > 0) {
    +      bootstrap.option(ChannelOption.SO_RCVBUF, conf.receiveBuf());
    --- End diff --
    
    For server side, netty leverages reactor pattern and `ServerBootstrap` is 
used here, method `option` works when socket binding and connecting occurs, 
while `childOption` works for the later process when connection is established 
and there will be one channel per client.
    For client side, spark rpc uses `Bootstrap`, there is no method to set 
`childOption` because client works not like server side, it is pretty simple 
for client, only one thread-pool will be used by netty to do network I/O.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to