Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19047#discussion_r135247004
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java ---
@@ -136,7 +136,8 @@ void addOptionString(List<String> cmd, String options) {
Set<String> cp = new LinkedHashSet<>();
addToClassPath(cp, appClassPath);
-
+ addToClassPath(cp, getenv("SPARK_DAEMON_CLASSPATH"));
--- End diff --
I think it would be better to only support this env variable for daemon
process like HistoryServer, ExternalShuffleService and others, like what we did
for `SPARK_DAEMON_JAVA_OPTS`. Currently with your fix normal Spark application
will also honor this env variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
