Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19050#discussion_r135394212
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
 ---
    @@ -98,6 +99,11 @@ object RewritePredicateSubquery extends 
Rule[LogicalPlan] with PredicateHelper {
               val (newCond, inputPlan) = 
rewriteExistentialExpr(Seq(predicate), p)
               Project(p.output, Filter(newCond.get, inputPlan))
           }
    +
    +      rewrotePlan transform {
    +        case j @ Join(left, right, _, _) if !j.duplicateResolved =>
    +          j.copy(right = DedupQueryAttributesInPlans.dedupRight(left, 
right))
    --- End diff --
    
    @viirya Thanks. We should be de-duping the subquery output in case of 
correlated subquery. Thats why i was wondering about how we are ending up with 
duplicate attributes. 
    @hvanhovell I had a question. Do we anticipate to have future rewrites to 
convert left-semi/left-anti joins to other types join such as inner join ? Can 
this be a problem then ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to