Github user YuvalItzchakov commented on a diff in the pull request:
https://github.com/apache/spark/pull/19059#discussion_r135397171
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -112,9 +112,15 @@ private[kafka010] case class CachedKafkaConsumer
private(
// we will move to the next available offset within `[offset,
untilOffset)` and retry.
// If `failOnDataLoss` is `true`, the loop body will be executed only
once.
var toFetchOffset = offset
- while (toFetchOffset != UNKNOWN_OFFSET) {
+ var consumerRecord: ConsumerRecord[Array[Byte], Array[Byte]] = null
+ // We want to break out of the while loop on a successful fetch to
avoid using "return"
+ // which may causes a NonLocalReturnControl exception when this method
is used as a function.
+ var isFetchComplete = false
+
+ while (toFetchOffset != UNKNOWN_OFFSET && !isFetchComplete) {
try {
- return fetchData(toFetchOffset, untilOffset, pollTimeoutMs,
failOnDataLoss)
+ consumerRecord = fetchData(toFetchOffset, untilOffset,
pollTimeoutMs, failOnDataLoss)
--- End diff --
Actually, this is an additional case that needs to be taken into account.
Ill look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
