Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r135403225
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala
---
@@ -32,7 +32,9 @@ import
org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl
* in that file.
*/
class HadoopFileLinesReader(
- file: PartitionedFile, conf: Configuration) extends Iterator[Text]
with Closeable {
+ file: PartitionedFile,
+ lineSeparator: Option[String],
--- End diff --
I was thinking `\n` means the first case of your comment above as it is set
by the user explicitly. So, I thought If it is not given, it covers three cases
of newlines by default. If we use `\n` to deal with three cases above, wouldn't
we are unable to cover, the arguably corner case of only handling `\n`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
