Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19029#discussion_r135411403
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -439,8 +439,9 @@ private[ml] object WeightedLeastSquares {
/**
* Weighted population standard deviation of labels.
+ * We prevent variance from negative value caused by numerical error.
--- End diff --
I'm not so against this, but this is really an implementation detail and
not relevant to the caller. It's a value that is by definition nonnegative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
