Github user mike0sv commented on a diff in the pull request:
https://github.com/apache/spark/pull/19066#discussion_r135511606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -81,19 +81,9 @@ object ExpressionEncoder {
ClassTag[T](cls))
}
- def javaEnumSchema[T](beanClass: Class[T]): DataType = {
- StructType(Seq(StructField("enum",
- StructType(Seq(StructField(beanClass.getSimpleName, StringType,
nullable = false))),
- nullable = false)))
- }
-
// TODO: improve error message for java bean encoder.
def javaBean[T](beanClass: Class[T]): ExpressionEncoder[T] = {
- val schema = if (beanClass.isEnum) {
- javaEnumSchema(beanClass)
- } else {
- JavaTypeInference.inferDataType(beanClass)._1
- }
+ val schema = JavaTypeInference.inferDataType(beanClass)._1
--- End diff --
If we don't support top level enums, maybe it would be appropriate to check
that beanClass is not enum and throw exception otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
