Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/19049#discussion_r135594814
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js
---
@@ -136,6 +136,16 @@ $(document).ready(function() {
(attempt.hasOwnProperty("attemptId") ? attempt["attemptId"] +
"/" : "") + "logs";
attempt["durationMillisec"] = attempt["duration"];
attempt["duration"] = formatDuration(attempt["duration"]);
+ var idStr = id.toString();
+ if(idStr.indexOf("application_") > -1) {
+ attempt["master"] = "yarn";
+ } else if(idStr.indexOf("app-") > -1) {
+ attempt["master"] = "standalone";
+ } else if(idStr.indexOf("local-") > -1) {
+ attempt["master"] = "local";
+ } else {
+ attempt["master"] = "mesos";
--- End diff --
Ok so I was mixing up `appId` and `name` but the issue still applies, this
is not a very good way to determine the RM, plus you missed the default case
that is used in tests and in case of error (`"spark-application-"`). Overall
I'm still not a fan of this PR though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
