Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/19069#discussion_r135645027
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/JoinBenchmark.scala
---
@@ -212,18 +212,17 @@ class JoinBenchmark extends BenchmarkBase {
sparkSession.conf.set("spark.sql.join.preferSortMergeJoin", "false")
runBenchmark("shuffle hash join", N) {
val df1 = sparkSession.range(N).selectExpr(s"id as k1")
- val df2 = sparkSession.range(N / 5).selectExpr(s"id * 3 as k2")
+ val df2 = sparkSession.range(N / 3).selectExpr(s"id * 3 as k2")
--- End diff --
Thanks for fixing this although I'm afraid this might break again if we
tweak the planner or the confs again. Can we please add an additional check
that looks for `ShuffledHashJoinExec` node in the `SparkPlan`? Something along
these lines:
```scala
assert(df.queryExecution.sparkPlan.find(_.isInstanceOf[ShuffledHashJoinExec]).isDefined)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
