Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r135663076
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -537,6 +537,11 @@ object SparkSubmit extends CommandLineUtils {
}
}
+ // SPARK-21568 ConsoleProgressBar should be enabled only in shells
--- End diff --
I'm not a fan of comments like this. It's just repeating what the code is
doing.
Instead, can you change the command to mention that it's ok to do this
because the user configuration is loaded later in this method and will override
this value if set?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
