Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19078#discussion_r135749198
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/PCA.scala ---
    @@ -44,6 +44,13 @@ class PCA @Since("1.4.0") (@Since("1.4.0") val k: Int) {
         require(k <= numFeatures,
           s"source vector size $numFeatures must be no less than k=$k")
     
    +    val workSize = ( 3
    --- End diff --
    
    I know it's copied from Breeze, but this is pretty unreadable and 
duplicates code. It's a bit fragile too. This doesn't really help, it just 
causes a different exception to be thrown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to