Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18787#discussion_r135863376
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
 ---
    @@ -1629,6 +1632,39 @@ class ArrowConvertersSuite extends SharedSQLContext 
with BeforeAndAfterAll {
         }
       }
     
    +  test("roundtrip payloads") {
    +    val allocator = ArrowUtils.rootAllocator.newChildAllocator("int", 0, 
Long.MaxValue)
    +    val vector = ArrowUtils.toArrowField("int", IntegerType, nullable = 
true)
    +      .createVector(allocator).asInstanceOf[NullableIntVector]
    +    vector.allocateNew()
    +    val mutator = vector.getMutator()
    +
    +    (0 until 10).foreach { i =>
    +      mutator.setSafe(i, i)
    +    }
    +    mutator.setNull(10)
    +    mutator.setValueCount(11)
    +
    +    val schema = StructType(Seq(StructField("int", IntegerType)))
    +
    +    val batch = new ColumnarBatch(schema, Array[ColumnVector](new 
ArrowColumnVector(vector)), 11)
    --- End diff --
    
    you mean just calling something like `new ColumnarBatch(..).rowIterator()`? 
 We still need to set the number of rows in the batch I believe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to