GitHub user sitalkedia opened a pull request:

    https://github.com/apache/spark/pull/19081

    [SPARK-21834] Incorrect executor request in case of dynamic allocation

    ## What changes were proposed in this pull request?
    
    killExecutor api currently does not allow killing an executor without 
updating the total number of executors needed. In case of dynamic allocation is 
turned on and the allocator tries to kill an executor, the scheduler reduces 
the total number of executors needed ( see 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala#L635)
 which is incorrect because the allocator already takes care of setting the 
required number of executors itself.
    
    
    
    ## How was this patch tested?
    
    Ran a job on the cluster and made sure the executor request is correct


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sitalkedia/spark 
skedia/oss_fix_executor_allocation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19081
    
----
commit 6cc5fab56110034e5221c40c5dfcc38e72f8c05a
Author: Sital Kedia <ske...@fb.com>
Date:   2017-08-29T02:29:27Z

    [SPARK-21834] Incorrect executor request in case of dynamic allocation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to