Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r18421303
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockClient.scala ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.network.netty
+
+import java.io.Closeable
+import java.util.concurrent.TimeoutException
+
+import scala.concurrent.{Future, promise}
+
+import io.netty.channel.{ChannelFuture, ChannelFutureListener}
+
+import org.apache.spark.Logging
+import org.apache.spark.network.{ManagedBuffer, BlockFetchingListener}
+import org.apache.spark.storage.StorageLevel
+
+
+/**
+ * Client for [[NettyBlockTransferService]]. The connection to server must
have been established
+ * using [[BlockClientFactory]] before instantiating this.
+ *
+ * This class is used to make requests to the server , while
[[BlockClientHandler]] is responsible
+ * for handling responses from the server.
+ *
+ * Concurrency: thread safe and can be called from multiple threads.
+ *
+ * @param cf the ChannelFuture for the connection.
+ * @param handler [[BlockClientHandler]] for handling outstanding requests.
+ */
+@throws[TimeoutException]
+private[netty]
+class BlockClient(cf: ChannelFuture, handler: BlockClientHandler) extends
Closeable with Logging {
+
+ private[this] val serverAddr = cf.channel().remoteAddress().toString
--- End diff --
If the channel is not connected, remoteAddress() may return null. We should
probably avoid an NPE here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
