Github user lgrcyanny commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19079#discussion_r135968835
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -481,7 +481,7 @@ object SparkSubmit extends CommandLineUtils {
             sysProp = "spark.executor.memory"),
           OptionAssigner(args.totalExecutorCores, STANDALONE | MESOS, 
ALL_DEPLOY_MODES,
             sysProp = "spark.cores.max"),
    -      OptionAssigner(args.files, LOCAL | STANDALONE | MESOS, 
ALL_DEPLOY_MODES,
    +      OptionAssigner(args.files, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
    --- End diff --
    
    I met some users complained about the wired action about SparkFiles.get in 
yarn-client and yarn-cluster mode. SparkFiles.get is very easy for user to get 
file path. why not keep the same action in yarn-cluster and yarn-client mode?
    Meanwhile, it not very easy for user to use spark.yarn.dist.files, it must 
be uploaded to HDFS in advance. To make spark on yarn more usable, use 
SparkFiles.get is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to