Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19080#discussion_r135970084
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
 ---
    @@ -153,6 +139,14 @@ case class EnsureRequirements(conf: SQLConf) extends 
Rule[SparkPlan] {
         val requiredChildOrderings: Seq[Seq[SortOrder]] = 
operator.requiredChildOrdering
         var children: Seq[SparkPlan] = operator.children
         assert(requiredChildDistributions.length == children.length)
    +
    +    val needCoPartitionChildIndex = 
requiredChildDistributions.zipWithIndex.filter {
    +      case (UnspecifiedDistribution, _) => false
    --- End diff --
    
    I don't think so. It's kind of a blacklist mechanism, only 2 special 
distribution doesn't need co-location.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to