Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18576#discussion_r135983831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -120,7 +120,25 @@ case class Generate(
case class Filter(condition: Expression, child: LogicalPlan)
extends UnaryNode with PredicateHelper {
- override def output: Seq[Attribute] = child.output
+
+ // The columns that will filtered out by `IsNotNull` could be considered
as not nullable.
+ private lazy val notNullAttributes =
splitConjunctivePredicates(condition).flatMap {
+ case isnotnull @ IsNotNull(a)
+ if isNullIntolerant(a) && a.references.subsetOf(child.outputSet) =>
+ isnotnull.references.map(_.exprId)
+ case _ =>
+ Seq.empty[ExprId]
+ }.toSet
+
+ override def output: Seq[Attribute] = {
+ child.output.map { a =>
+ if (a.nullable && notNullAttributes.contains(a.exprId)) {
--- End diff --
The same issue also applies to the other nodes. Filter is just one of them,
if we use constraints to determine whether they are nullable or not
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
