Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2455#issuecomment-57874204
@erikerlandson I didn't check the test code. I will try to find another
time to make a pass on the test. The implementation looks good to me except
minor inline comments. Could you create a JIRA for `.drop(...)` in sampling and
link it to the upstream Scala JIRA? So we will remember to update it later.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
