Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19099#discussion_r136479931
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2663,4 +2664,31 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         // In unit test, Spark will fail the query if memory leak detected.
         spark.range(100).groupBy("id").count().limit(1).collect()
       }
    +
    +  test("SPARK-21652: rule confliction of InferFiltersFromConstraints and 
ConstantPropagation") {
    +    // Under test environment, throws Exception if the max iteration 
number is reached for an
    --- End diff --
    
    Just catching the exception is not enough for this test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to