Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18931#discussion_r136711099
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala ---
    @@ -177,6 +177,8 @@ case class SortExec(
          """.stripMargin.trim
       }
     
    +  override protected def doConsumeInChainOfFunc: Boolean = false
    --- End diff --
    
    I think it's better to put the reason why we set false explicitly in each 
plan like 
https://github.com/apache/spark/pull/18931/files#diff-28cb12941b992ff680c277c651b59aa0R204
    
    btw, we can have better naming for this? e.g., `canPipeline`, or something 
because IIUC this optimisation can be applied in `pipelining` operators 
(`pipeling` is one of database terminology: 
https://link.springer.com/referenceworkentry/10.1007%2F978-0-387-39940-9_872).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to