Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19124#discussion_r136910147
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -169,6 +172,18 @@ class OrcFileFormat extends FileFormat with
DataSourceRegister with Serializable
}
}
}
+
+ private def checkFieldName(name: String): Unit = {
+ try {
+ TypeDescription.fromString(s"struct<$name:int>")
+ } catch {
+ case _: IllegalArgumentException =>
+ throw new AnalysisException(
+ s"""Attribute name "$name" contains invalid character(s).
--- End diff --
Nit: `Attribute`-> `Column`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
