Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r137050480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
foldFunctions: Seq[String] => String = _.mkString("", ";\n", ";")):
String = {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
+ val defaultMaxLines = 100
+ val maxLines = if (SparkEnv.get != null) {
+
SparkEnv.get.conf.getInt("spark.sql.codegen.expressions.maxCodegenLinesPerFunction",
--- End diff --
There are multiple related PRs. Maybe we can wait until the reviews are
finished there?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
