Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19124#discussion_r137174215 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -206,6 +206,9 @@ case class AlterTableAddColumnsCommand( reorderedSchema.map(_.name), "in the table definition of " + table.identifier, conf.caseSensitiveAnalysis) + val newDataSchema = StructType(catalogTable.dataSchema ++ columns) + DDLUtils.checkFieldNames(catalogTable.copy(schema = newDataSchema)) --- End diff -- Ur, actually. Excluding partition columns was intentional. Maybe, I used a misleading PR title and description here. So far, I checked `dataSchema` only. I think partition columns are okay because they are not a part of Parquet/ORC file schema.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org