Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1980#discussion_r18432489
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -180,12 +186,32 @@ private[spark] object JettyUtils extends Logging {
serverName: String = ""): ServerInfo = {
val collection = new ContextHandlerCollection
- collection.setHandlers(handlers.toArray)
addFilters(handlers, conf)
// Bind to the given port, or throw a java.net.BindException if the
port is occupied
def connect(currentPort: Int): (Server, Int) = {
- val server = new Server(new InetSocketAddress(hostName, currentPort))
+ val server = new Server
+ // Create a connector on port currentPort to listen for HTTP requests
+ val httpConnector = new SelectChannelConnector()
+ httpConnector.setPort(currentPort)
+ httpConnector.setHost(hostName)
+
+ if (conf.get("spark.ui.https.enabled", "false").toBoolean) {
+ // / If the new port wraps around, do not try a privilege port
+ val securePort = (currentPort + 1 - 1024) % (65536 - 1024) + 1024
--- End diff --
What if this port isn't free? It's dangerous to make assumptions about
whether a particular ports is free, especially since this can cause problems in
Jenkins, where we might have multiple builds running concurrently on the same
machine that are contending for ports.
Could we use `Utils.startServiceOnPort` for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
