Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18982#discussion_r137360294
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -118,11 +118,13 @@ def _transfer_params_to_java(self):
"""
Transforms the embedded params to the companion Java object.
"""
- paramMap = self.extractParamMap()
for param in self.params:
- if param in paramMap:
- pair = self._make_java_param_pair(param, paramMap[param])
+ if param in self._paramMap:
+ pair = self._make_java_param_pair(param,
self._paramMap[param])
self._java_obj.set(pair)
+ if param in self._defaultParamMap:
--- End diff --
Sounds reasonable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
