Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19077#discussion_r137361142
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java
 ---
    @@ -47,23 +47,29 @@ private boolean shouldPool(long size) {
     
       @Override
       public MemoryBlock allocate(long size) throws OutOfMemoryError {
    -    if (shouldPool(size)) {
    +    int arraySize = (int)((size + 7) / 8);
    --- End diff --
    
    Maybe we should make the method to tackle long values.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to