Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17096#discussion_r137369131
--- Diff: python/pyspark/ml/tests.py ---
@@ -319,6 +320,20 @@ def test_hasparam(self):
testParams = TestParams()
self.assertTrue(all([testParams.hasParam(p.name) for p in
testParams.params]))
self.assertFalse(testParams.hasParam("notAParameter"))
+ self.assertTrue(testParams.hasParam(u"maxIter"))
+
+ def test_resolveparam(self):
+ testParams = TestParams()
+ self.assertEqual(testParams._resolveParam(testParams.maxIter),
testParams.maxIter)
+ self.assertEqual(testParams._resolveParam("maxIter"),
testParams.maxIter)
+
+ self.assertEqual(testParams._resolveParam(u"maxIter"),
testParams.maxIter)
+ if sys.version_info[0] >= 3:
--- End diff --
Yes! :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
