Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137386317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
/**
- * Add an INSERT INTO [TABLE]/INSERT OVERWRITE TABLE operation to the
logical plan.
+ * Parameters used for writing query to a table:
+ * (tableIdentifier, partitionKeys, overwrite, exists).
+ */
+ type InsertTableParams = (TableIdentifier, Map[String, Option[String]],
Boolean, Boolean)
+
+ /**
+ * Parameters used for writing query to a directory: (isLocal,
CatalogStorageFormat, provider).
+ */
+ type InsertDirParams = (Boolean, CatalogStorageFormat, Option[String])
+
+ /**
+ * Add an
+ * INSERT INTO [TABLE] or
+ * INSERT OVERWRITE TABLE or
+ * INSERT OVERWRITE [LOCAL] DIRECTORY
+ * operation to logical plan
*/
private def withInsertInto(
ctx: InsertIntoContext,
query: LogicalPlan): LogicalPlan = withOrigin(ctx) {
+ ctx match {
+ case table : InsertIntoTableContext =>
--- End diff --
Nit: `table :`-> `table:`
The same issue in line 206
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
