Github user parente commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18339#discussion_r137616353
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -33,14 +33,18 @@
     from pyspark.serializers import read_int
     
     
    -def launch_gateway(conf=None):
    +def launch_gateway(conf=None, popen_kwargs=None):
    --- End diff --
    
    Would a comment in the docstring to that effect be better? I haven't seen 
`_var_name` used in Python projects to indicate a developer feature. (But of 
course, maybe I've just not seen it yet!)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to