Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19134#discussion_r137867121
  
    --- Diff: python/pyspark/streaming/tests.py ---
    @@ -1051,6 +1062,9 @@ def test_kafka_stream(self):
     
         def test_kafka_direct_stream(self):
             """Test the Python direct Kafka stream API."""
    +        if not are_kafka_tests_enabled:
    --- End diff --
    
    Wouldn't it be simpler to follow the kinesis example?
    
    The code checks this once in the `__main__` section, and if tests are 
disabled the suite is not added to the list of suites to be run.
    
    Also, am I reading things wrong, or there are no tests for the 0.10 backend 
here? Is the 0.10 backend supported in pyspark?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to