GitHub user original-brownbear opened a pull request:

    https://github.com/apache/spark/pull/19180

    [SPARK-21967][CORE] org.apache.spark.unsafe.types.UTF8String#compareTo 
Should Compare 8 Bytes at a Time for Better Performance

    ## What changes were proposed in this pull request?
    
    * Using 64 bit unsigned long comparison instead of unsigned int comparison 
in `org.apache.spark.unsafe.types.UTF8String#compareTo` for better performance.
    * Making `IS_LITTLE_ENDIAN` a constant for correctness reasons (shouldn't 
use a non-constant in `compareTo` implementations and it def. is a constant per 
JVM)
    
    ## How was this patch tested?
    
    Build passes and the functionality is widely covered by existing tests as 
far as I can see.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/original-brownbear/spark SPARK-21967

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19180
    
----
commit f6b185291a11d84ce96237f6e29ebee8cc175b86
Author: Armin <[email protected]>
Date:   2017-09-10T13:19:51Z

    [SPARK-21967][CORE] org.apache.spark.unsafe.types.UTF8String#compareTo 
Should Compare 8 Bytes at a Time for Better Performance

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to