[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

[wangyum]

Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18853#discussion_r137965884
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -1966,7 +1966,7 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
     
       test("SPARK-17913: compare long and string type column may return 
confusing result") {
         val df = Seq(123L -> "123", 19157170390056973L -> 
"19157170390056971").toDF("i", "j")
    -    checkAnswer(df.select($"i" === $"j"), Row(true) :: Row(false) :: Nil)
    +    checkAnswer(df.select($"i" === $"j"), Row(true) :: Row(true) :: Nil)
    --- End diff --
    
    To compatible with Hive, MySQL and Oracle:
    <img width="1319" alt="oracle" 
src="https://user-images.githubusercontent.com/5399861/30254791-f2e6cc28-96cf-11e7-817e-c837c42d7504.png";>



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org