Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18887#discussion_r137942697
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -301,9 +334,13 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
       }
     
       override def stop(): Unit = {
    -    if (initThread != null && initThread.isAlive()) {
    -      initThread.interrupt()
    -      initThread.join()
    +    try {
    +      if (initThread != null && initThread.isAlive()) {
    +        initThread.interrupt()
    +        initThread.join()
    +      }
    +    } finally {
    +      listing.close()
    --- End diff --
    
    What might happen if `LevelDB` is not properly closed?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to