GitHub user scwf opened a pull request:

    https://github.com/apache/spark/pull/2671

    [SPARK-3809][SQL]fix HiveThriftServer2Suite to make it work correctly

    Currently HiveThriftServer2Suite is a fake one, actually HiveThriftServer 
not even started there. Issues here:
    1 Thriftserver not started. Testing will get this error ---
    ERROR HiveThriftServer2Suite: Failed to start Hive Thrift server within 30 
seconds
    java.util.concurrent.TimeoutException: Futures timed out after [30 seconds]
    2 Thriftserver not stoped. After test finished the process of thriftserver 
did not exit.
    
    This patch fix this problems as follows:
    1 Since thriftserver started as a daemon in  
https://github.com/apache/spark/pull/2509, output of 
the```start-thriftserver.sh``` has be redirect to a log file such as 
```spark-kf-org.apache.spark.sql.hive.thriftserver.HiveThriftServer2-1-kf.out```,
 so to see whether this file contain "ThriftBinaryCLIService listening on" ` to 
assert server started successfully
    
    2 Start server in ```beforeAll```
    
    3 stop server in ```afterAll```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scwf/spark fix-HiveThriftServer2Suite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2671
    
----
commit c39d0a5eabc1f505117e711c17a48b089b266483
Author: scwf <wangf...@huawei.com>
Date:   2014-10-06T09:45:41Z

    fix HiveThriftServer2Suite

commit 0081a508f147a2b7bd7065149b8d3da308ba3d37
Author: scwf <wangf...@huawei.com>
Date:   2014-10-06T09:51:14Z

    fix code format

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to