Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r138232491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -193,14 +223,35 @@ private[sql] class JacksonGenerator(
*
* @param row The row to convert
*/
- def write(row: InternalRow): Unit = writeObject(writeFields(row, schema,
rootFieldWriters))
+ def write(row: InternalRow): Unit = {
+ writeObject(writeFields(
+ fieldWriters = rootFieldWriters,
+ row = row,
+ schema = dataType.asInstanceOf[StructType]))
+ }
+
+
+ /**
+ * Transforms multiple `InternalRow`s or `MapData`s to JSON array using
Jackson
+ *
+ * @param array The array of rows or maps to convert
+ */
+ def write(array: ArrayData): Unit = writeArray(writeArrayData(
+ fieldWriter = arrElementWriter,
+ array = array
+ ))
/**
- * Transforms multiple `InternalRow`s to JSON array using Jackson
+ * Transforms a single `MapData` to JSON object using Jackson
*
- * @param array The array of rows to convert
+ * @param map a map to convert
*/
- def write(array: ArrayData): Unit = writeArray(writeArrayData(array,
arrElementWriter))
+ def write(map: MapData): Unit = {
+ writeObject(writeMapData(
+ fieldWriter = mapElementWriter,
--- End diff --
And also add a similar comment in `write(row: InternalRow)`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
