Github user j-baker commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19136#discussion_r138282764
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/downward/CatalystFilterPushDownSupport.java
 ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.sources.v2.reader.downward;
    +
    +import org.apache.spark.annotation.Experimental;
    +import org.apache.spark.annotation.InterfaceStability;
    +import org.apache.spark.sql.catalyst.expressions.Expression;
    +
    +/**
    + * A mix-in interface for `DataSourceV2Reader`. Users can implement this 
interface to push down
    + * arbitrary expressions as predicates to the data source.
    + */
    +@Experimental
    +@InterfaceStability.Unstable
    +public interface CatalystFilterPushDownSupport {
    +
    +  /**
    +   * Push down filters, returns unsupported filters.
    +   */
    +  Expression[] pushCatalystFilters(Expression[] filters);
    --- End diff --
    
    any chance this could push java lists? They're just more idiomatic in a 
java interface


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to