Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18704#discussion_r138409856 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -147,6 +147,11 @@ private void throwUnsupportedException(int requiredCapacity, Throwable cause) { public abstract void putShorts(int rowId, int count, short[] src, int srcIndex); /** + * Sets values from [rowId, rowId + count) to [src[srcIndex], src[srcIndex + count]) --- End diff -- @ueshin Line 145 may make a mistake in comment `Sets values from [rowId, rowId + count) to [src + srcIndex, src + srcIndex + count)` It should be `Sets values from [src + srcIndex, src + srcIndex + count) to [rowId, rowId + count)` What do you think? If so, should we update them in this PR? Or, is it better to create another PR?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org