Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19219#discussion_r138585002
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
    @@ -116,7 +116,10 @@ private[hive] object SparkSQLCLIDriver extends Logging 
{
         SessionState.start(sessionState)
     
         // Clean up after we exit
    -    ShutdownHookManager.addShutdownHook { () => SparkSQLEnv.stop() }
    +    ShutdownHookManager.addShutdownHook { () =>
    +      sessionState.close()
    --- End diff --
    
    I don't know if it matters, but keep in mind this will hold a reference to 
sessionState then until the JVM exits


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to