Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r138744794
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java 
---
    @@ -46,6 +47,42 @@ public static int roundNumberOfBytesToNearestWord(int 
numBytes) {
        * @return true if the arrays are equal, false otherwise
        */
       public static boolean arrayEquals(
    +      MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long 
rightOffset, final long length) {
    --- End diff --
    
    Is there any semantic difference between this method and one right below ? 
Can we do `getBaseObject()` over the `leftBase` and `rightBase` and call the 
method below at L#85 ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to