Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/19181#discussion_r138751518
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -85,7 +85,7 @@
private final LinkedList<UnsafeSorterSpillWriter> spillWriters = new
LinkedList<>();
// These variables are reset after spilling:
- @Nullable private volatile UnsafeInMemorySorter inMemSorter;
+ @VisibleForTesting @Nullable volatile UnsafeInMemorySorter inMemSorter;
--- End diff --
@hvanhovell , is it acceptable to a method indicating if the next inset is
going to spill? Can make this @VisibleForTest and prefixed with something like
testOnly
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
