Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19130#discussion_r138827462
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala 
---
    @@ -123,6 +123,11 @@ private[deploy] object DependencyUtils {
     
         uri.getScheme match {
           case "file" | "local" => path
    +      case "http" | "https" | "ftp" if Utils.isTesting =>
    --- End diff --
    
    @vanzin , it is a little difficult to mock the download behavior, so here I 
check if "spark.testing" is configured, return a dummy local path if it is 
configured. What do you think about this approach?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to