Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2670#issuecomment-58059674
So, I've never been a fan of `File.deleteOnExit()`, and just to make sure
my dislike was not unfounded, I wrote the following code:
import java.io.*;
class d { public static void main(String[] args) throws Exception {
File d = new File("/tmp/foo");
d.mkdir();
d.deleteOnExit();
File f = new File(d, "bar");
Writer out = new FileWriter(f);
out.close();
} }
And sure enough, after you run it, `/tmp/foo` and its child file are still
there. I don't know if this applies to your patch (will be going through it
next), but in general, whenever I see a `deleteOnExit()` call somewhere, it
just feels like laziness to properly clean things up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
