Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19231#discussion_r138948476
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -993,7 +996,10 @@ class JDBCSuite extends SparkFunSuite
Seq(StructField("NAME", StringType, true), StructField("THEID",
IntegerType, true)))
val df = sql("select * from people_view")
assert(df.schema.size === 2)
- assert(df.schema === schema)
--- End diff --
We shouldn't change it, because `scale` is used to infer column types:
https://github.com/apache/spark/blob/v2.2.0/sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala#L32
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
