Github user klion26 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19145#discussion_r139125435
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -158,6 +158,7 @@ private[yarn] class YarnAllocator(
private[yarn] val containerPlacementStrategy =
new LocalityPreferredContainerPlacementStrategy(sparkConf, conf,
resource, resolver)
+ private[yarn] val completedContainerIdSet: HashSet[ContainerId] = new
HashSet[ContainerId]()
--- End diff --
My friend told me the completedContainer will only be reported twice, if
that's true, we could use `completedContainerIdSet.remove(containerId)` instead
of `completedContainerIdSet.contains(containerId)` as I said above.
But I can't confirm that, I don't know much about Yarn.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
