Github user kevinyu98 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12646#discussion_r139278830
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ---
    @@ -1179,6 +1179,26 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
        * Create a (windowed) Function expression.
        */
       override def visitFunctionCall(ctx: FunctionCallContext): Expression = 
withOrigin(ctx) {
    +    def replaceFunctions(
    +      funcID: FunctionIdentifier,
    +      ctx: FunctionCallContext): FunctionIdentifier = {
    +        val opt = ctx.trimOption
    +        if (opt != null) {
    +          if (ctx.qualifiedName.getText.toLowerCase != "trim") {
    --- End diff --
    
    I changed to toLowerCase(Locale.ROOT)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to