GitHub user huaxingao opened a pull request:

    https://github.com/apache/spark/pull/19256

    [SPARK-21338][SQL]implement isCascadingTruncateTable() method in Aggr…

    …egatedDialect
    
    ## What changes were proposed in this pull request?
    
    org.apache.spark.sql.jdbc.JdbcDialect's method:
    def isCascadingTruncateTable(): Option[Boolean] = None
    is not overriden in org.apache.spark.sql.jdbc.AggregatedDialect class.
    Because of this issue, when you add more than one dialect Spark doesn't 
truncate table because isCascadingTruncateTable always returns default None for 
Aggregated Dialect. 
    Will implement isCascadingTruncateTable in AggregatedDialect class in this 
PR. 
    
    ## How was this patch tested?
    
    In JDBCSuite, inside test("Aggregated dialects"), will add one line to test 
AggregatedDialect.isCascadingTruncateTable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huaxingao/spark spark-21338

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19256
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to