Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19249#discussion_r139305674
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -483,7 +483,8 @@ def __init__(self, fields=None):
                 self.names = [f.name for f in fields]
                 assert all(isinstance(f, StructField) for f in fields),\
                     "fields should be a list of StructField"
    -        self._needSerializeAnyField = any(f.needConversion() for f in self)
    +        self._needConversion = [f.needConversion() for f in self]
    --- End diff --
    
    I'd rename this to another, for example, `_needConversions` (or others if 
there are) and leave a comment here why we do this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to