Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r139344378
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
}
private def createTestConf(): SparkConf = {
- new SparkConf().set("spark.history.fs.logDirectory",
testDir.getAbsolutePath())
+ new SparkConf()
+ .set("spark.history.fs.logDirectory", testDir.getAbsolutePath())
+ .set(LOCAL_STORE_DIR, Utils.createTempDir().getAbsolutePath())
--- End diff --
Since we set `LOCAL_STORE_DIR` to a directory, it will not test the
in-memory one.
Do we need another test suite that extend this one? For example,
[ExternalCatalogSuite.scala](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala)
is an abstract class. There are two test suites based on this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
