Github user derrickburns commented on the pull request:
https://github.com/apache/spark/pull/2634#issuecomment-58106509
@mengxr
Is there an IntelliJ or Eclipse configuration that i can use to reformat
the code according to the guidelines?
The breaking change in the PR is for a private constructor that is,
therefore, not used outside of Spark. Do these need to be deprecated first
as well?
On Mon, Oct 6, 2014 at 2:53 PM, Xiangrui Meng <[email protected]>
wrote:
> @derrickburns <https://github.com/derrickburns> I marked a few style
> problems (not all of them). There are breaking changes in your PR, which
we
> should avoid as much as possible. Even we want to remove some methods, we
> should deprecate them first and remove them in a later release.
>
> For the serialization problem, I'm not sure whether I have time looking
> into it this week. It would be nice to split this into small PRs, so we
can
> trace down the problem faster.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2634#issuecomment-58106056>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
